Skip to content

Added MUSCL #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Added MUSCL #921

wants to merge 4 commits into from

Conversation

@okBrian
Copy link
Contributor

@okBrian okBrian commented Jul 7, 2025 •
edited
Loading

Description

Added MUSCL Reconstruction, and Interface Compression

Fixes #277

Type of change

  • New feature (non-breaking change which adds functionality)

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

  • Regression Tests
  • 1D Sodshocktube
  • 2D Advection
  • 2D Shockdroplet
  • 2D Riemann Test
  • 3D Shockdroplet
  • 3D Rayleigh Taylor

Test Configuration:
GT Phoenix, Frontier, and Locally

Checklist

  • I have added comments for the new code
  • I added Doxygen docstrings to the new code
  • I have made corresponding changes to the documentation (docs/)
  • I have added regression tests to the test suite so that people can verify in the future that the feature is behaving as expected
  • I have added example cases in examples/ that demonstrate my new feature performing as expected.
    They run to completion and demonstrate "interesting physics"
  • I ran ./mfc.sh format before committing my code
  • New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)

To make sure the code is performing as expected on GPU devices, I have:

  • Checked that the code compiles using NVHPC compilers
  • Checked that the code compiles using CRAY compilers
  • Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
  • Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
  • Enclosed the new feature via nvtx ranges so that they can be identified in profiles
  • Ran a Nsight Systems profile using ./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR
  • Ran a Rocprof Systems profile using ./mfc.sh run XXXX --gpu -t simulation --rsys --hip-trace, and have attached the output file and plain text results to this PR.
  • Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature

@codecov
Copy link

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.20690% with 259 lines in your changes missing coverage. Please review.

Project coverage is 43.75%. Comparing base (1e74a60) to head (dac5df5).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_viscous.fpp 12.50% 71 Missing and 6 partials ⚠️
src/simulation/m_muscl.fpp 50.00% 45 Missing and 23 partials ⚠️
src/simulation/m_rhs.fpp 29.62% 36 Missing and 2 partials ⚠️
src/simulation/m_surface_tension.fpp 0.00% 30 Missing and 1 partial ⚠️
src/simulation/m_cbc.fpp 17.24% 21 Missing and 3 partials ⚠️
src/simulation/m_checker.fpp 50.00% 5 Missing and 1 partial ⚠️
src/common/m_checker_common.fpp 50.00% 4 Missing and 1 partial ⚠️
src/common/m_mpi_common.fpp 66.66% 2 Missing and 1 partial ⚠️
src/common/m_helper_basic.f90 71.42% 0 Missing and 2 partials ⚠️
src/simulation/m_global_parameters.fpp 84.61% 0 Missing and 2 partials ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
- Coverage   44.15%   43.75%   -0.40%     
==========================================
  Files          68       69       +1     
  Lines       18347    18552     +205     
  Branches     2227     2270      +43     
==========================================
+ Hits         8101     8118      +17     
- Misses       8943     9113     +170     
- Partials     1303     1321      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@okBrian okBrian closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbryngelson sbryngelson Awaiting requested review from sbryngelson sbryngelson will be requested when the pull request is marked ready for review sbryngelson is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add MUSCL Reconstruction

1 participant

@okBrian